Disallow non-default expectedExecutionsPerDeployment in evmasm tests when only a creation object is present
#16023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
added
testing 🔨
has dependencies
cameel
force-pushed
the
subassemblies-in-evm-assembly-tests
branch
from
12f8750 to
202933b
Compare
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
matheusaaguiar
removed
the
stale
matheusaaguiar
approved these changes
May 20, 2025
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
matheusaaguiar
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #16021.
This adds an extra check to prevent confusion like in #16012 (comment).
expectedExecutionsPerDeploymentonly affects runtime assemblies, but the top-level assembly is a creation one so if you have only one, it will seem like the setting is not working. This PR makes the test case throw an exception in that situation to make it obvious. It is not likely to be intentional.I did not include it in #16021, because I'm not yet 100% convinced we want this. There are some downsides:
--import-asm-jsonwould just accept it.Still, these seem minor enough that we're probably better off with this check than without it.